On 12/01/11 04:11, Saurabh Vyas wrote:
<< initiating this review on behalf of Thejaswini >>
Hi All,
Please review these trivial fixes and let me know your comments.
18958 Error message concerning /var/pkg/lock & lack of privileges could
be improved
7095081 installupdate.py has typo: 'futher' instead of 'further'
webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/18958/webrev/
I don't think the changes in src/modules/client/api_errors.py will
really "fix" things.
The original \n was placed there to ensure the message wrapped in most
cases.
While moving the \n as you have improves this specific case, it may make
others worse. Recall that any pathname could be placed there, and some
are very long.
We should just remove the \n's from these messages and then enforce
wrapping using our own custom output routines at runtime. But that's
not a simple change.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
