On 12/01/11 22:00, Brock Pytlik wrote:
On 12/01/11 13:32, Shawn Walker wrote:
On 12/01/11 04:11, Saurabh Vyas wrote:
<< initiating this review on behalf of Thejaswini >>
Hi All,
Please review these trivial fixes and let me know your comments.
18958 Error message concerning /var/pkg/lock & lack of privileges could
be improved
7095081 installupdate.py has typo: 'futher' instead of 'further'
webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/18958/webrev/
I don't think the changes in src/modules/client/api_errors.py will
really "fix" things.
In fairness, isn't /var/pkg/lock the common manifestation of this error
message? I agree that our own custom output routines would be
preferable, but we've also been saying we should have those for quite a
while, so it doesn't seem to be a priority. It seems to me that this
improves the common case. The easy to implement alternative I would be
fine with would be to just wrap the line after the path is printed.
If we want a simpler fix, I think the right answer would be to add a new
exception for this specific case and tailor the error message to fit.
That would actually be more easily understood than simply reformatting
the permissions exception error and resolve the original issue.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
