On Thu, Jan 26, 2012 at 01:16:50PM -0800, Brock Pytlik wrote: > On 01/25/12 18:33, Edward Pilatowicz wrote: > >hey all, > > > >i have an updated webrev that i believe addresses all the previous > >comments: > > > > https://cr.opensolaris.org/action/browse/pkg/edp/pkgplan_cleanup3/webrev > > 19137 package plan object should be easier to serialize > > > >thanks, > >ed > >_______________________________________________ > >pkg-discuss mailing list > >[email protected] > >http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > license.py: > 69-72: It seems strange to me that we jump through a bunch of hoops > on lines 69-72 to get a path relative to the image's root, and then > we get a path rooted in the image. Do pkgplan.image.root and > pkgplan.image.get_root() point to different locations? If not, then > it seems like this could be simplified. (If nothing else, settling > on either .root or .get_root() would be nice). >
looking at the other actions, most of them use .get_root() instead of .root, so i changed the .root here to a .get_root(). the webrev has been updated. thanks for looking at this, ed _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
