On Thu, Jan 26, 2012 at 06:15:04AM -0800, Shawn Walker wrote: > On 01/25/12 18:33, Edward Pilatowicz wrote: > >hey all, > > > >i have an updated webrev that i believe addresses all the previous > >comments: > > > > https://cr.opensolaris.org/action/browse/pkg/edp/pkgplan_cleanup3/webrev > > 19137 package plan object should be easier to serialize > > src/modules/actions/license.py: > Why the changes in license.py to nuke preinstall? The comment > claims its necessary for filelist support to work. We weren't > intending to remove old repo support yet. >
oops. i didn't realize that the repo was still using filelist support. (i saw 9629 and assumed that filelist support was all EOL'd.) i'll restore preinstall(). the reason i had this change was because in my parallel linked images gate i want to be able to do planning, preparation, and execution in separate processes without having to re-do previous stages. (today we when we do recursion we re-execute previous stages, so for example, when we go to execute a plan on a child image, we redo the planning and preparation stages before running the execution, even though we've already done planning twice and preparation once before.) this means i wanted to support calling install() without first having to invoke preinstall(). i'll leave that change in the parallel linked image gate. > src/tests/api/t_linked_image.py: > line 328, 1261: extra newlines > fixed. the webrev has been updated. thanks for looking at this, ed _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
