Greetings,

The following webrev contains an image state fix and a performance fix for the following issues:

  7136803 get_pkg_list returns installed package as upgradable after
          newer version is no longer available
  7141119 pkg client up-to-date check could be faster

webrev:
  https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-update-1/webrev/

ipkg_is_up_to_date in pkg.client.image does far more work than it actually needs to do most of the time. Instead, it should be sufficient to simply test that there is a newer version of "package/pkg" available and that it is allowed by the installed "consolidation/ips/ips-incorporation" package.

Making those changes gives a ~8 second reduction in "pkg update -n" time on my x86 system, both in the case that there is no newer version of package/pkg available, and in the case that there is, but it isn't for the currently installed OS build (i.e. ips-incorporation doesn't allow it). On a sparc T4 system, these changes provide a ~12 second reduction in "pkg update -n" time.

As of today, after these changes (plus ones in the previous two builds), planning an update only takes ~25s on my system with all nightly publishers configured. (That's compared to 1m20s a few builds ago.)

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to