On 01/30/12 21:29, Danek Duvall wrote:
Shawn Walker wrote:

   https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-update-1/webrev/

My only comments are on a comment, neither terribly important:

   - line 4321: I'd replace "the update planning" with something talking
     about the solver, since that's the step we're really trying to avoid,
     right?  Perhaps "... then we can bypass the solver if none ...".

   - line 4322-4323: I'm not sure what the install hold has to do with this,
     but I don't think mentioning it here adds any value.

So changed.

Thanks,
-Shawn

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to