On 02/23/12 21:03, Abhinandan Ekande wrote:
Folks,
Please review fix for CR :
7120902 var/cache/pkg/sysrepo recreated with broken perms
webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7120902-rev1/webrev/
Unit testing done :
* Removed the directory /var/cache/pkg/sysrep
* Then enabled the system-repository servic
* Verified that service is comes online
* Verified the permission on the directory, /var/cache/pkg/sysrep
Here are details :
# rmdir /var/cache/pkg/sysrepo
# svcadm enable svc:/application/pkg/system-repository:default
# svcs -a | grep system-repository
online 9:10:25 svc:/application/pkg/system-repository:default
# ls -ld /system/volatile/pkg/sysrepo
drwxr-xr-x 3 root root 322 Feb 23 09:10 /system/volatile/pkg/sysrepo
# ls -ld /var/cache/pkg/sysrepo
drwxr-xr-x 2 root root 2 Feb 23 09:10 /var/cache/pkg/sysrepo
# ls -ld /var/log/pkg/sysrepo
drwxr-xr-x 2 root bin 5 Feb 23 09:10 /var/log/pkg/sysrepo
Thanks,
Abhi.
This change looks correct, but I'd like to see a test added to pkg's
test suite to check for this condition. In addition, I'm curious about
the user and group, shouldn't we make sure that the directory is created
as pkg5srv, and not root as described in the bug?
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
