Hi there,
On 03/ 6/12 11:45 PM, Abhinandan Ekande wrote:
Tim, as per discussion with you over IM I have made the changes.
The updated webrev is located at :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7120902-rev4/webrev/
This looks fine, with the one addition, that it'd be nice if sysrepo.py
still ran as non-root. You could check $PKG5_TEST_ENV when trying to
chown to pkg5srv - see line 502 for an example.
cheers,
tim
Please let me know your comments.
Thanks,
Abhi.
On 03/05/12 14:06, Abhinandan Ekande wrote:
On 03/05/12 03:49, Tim Foster wrote:
You're right, sorry - I was led astray by the creative use of
'dir.find' there. Any reason why you didn't use 'dir == foo' rather
than 'dir.find(foo)'?
I will do check as you have suggested.
Also, rather than relying on the user and group of the parent
directories of the cache_dir being set correctly, it's probably
better to use the 'SYSREPO_USER' and 'SYSREPO_GROUP' globals - see
line 497 for an example.
The SYSREPO_GROUP is initialized as 'pkg5srv'. As per manifest the gid
for
cache directory is 'bin'. Therefore I took the route of setting user
and group as per
parent directory of cache directory. Is it okay to set group as
'pkg5srv' for cache
directory ? Or is initializing of SYSREPO_GROUP incorrect ? Please let
me know.
Thanks,
Abhi.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
--
Oracle
Abhinandan Ekande
Solaris Install,
Revenue Product Engineering (RPE), Systems
Phone: +91 8041847267 | Fax: +91 80 22231794 | Mobile: +91 9632144088
ORACLE India | Off Langford Road | Bangalore | 560025
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
