On Tue, Mar 06, 2012 at 10:08:00AM +1300, Tim Foster wrote: > I've got an incremental, and new webrev at: > https://cr.opensolaris.org/action/browse/pkg/timf/poisoned-cache-v2/
On lines 1286-1298 and 1887-1899 you're not recording the fact that you've seen a content error, which is going to skew the repository statistics for future choices. In general, I'm not really thrilled with this approach. It might be simpler to set the cache-clearing headers on any subsequent attempt to connect to a repository that has already given us a content error. To do this, you'd want to add the iteration count to gen_repos, as Shawn suggested. You'll also want to add a content_errors property to the repo statistics, in stats.py. Then, instead of doing a big dance with adjusting the retry count on the fly, simply record a content error when verification fails. At the beginning of the 'for d, v in self.__gen_repo()' loop, you can check whether you're on a subsequent iteration, and if so, look at the repostats to determine if you've seen a content error. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
