On Wed, Mar 07, 2012 at 05:39:11PM +1300, Tim Foster wrote:
> Ok, I've had another go at this, and have a webrev at:
>
> https://cr.opensolaris.org/action/browse/pkg/timf/poisoned-cache-v3
Thanks for making these modifications. I like this change. Just a few
nits:
stats.py:
- line 320: typo "operaiton" should be "operation"
transport.py:
- lines 1870-1874: The TransportFailures object is designed to
accumulate multiple exceptions, and pretty-print them once we reach
the maximum number of retries. Unless I've misunderstood what
you're trying to accomplish, it looks like this could be simplified
to the following:
except tx.InvalidContentException, e:
repostats.record_error(content=True)
failures.append(apx.InvalidDepotResponseException(
d.get_url(), "Unable to parse "
"repository's versions/0 response"))
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
