On 03/ 9/12 06:40 AM, Shawn Walker wrote:
On 03/02/12 18:06, Shawn Walker wrote:
https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-bui/webrev/
src/modules/server/api.py:
gen_allowed_packages(..)
This takes a single fmri (an incorporation) following its dependencies.
Would the API be more useful if it allowed a list of fmris instead,
which would mean all packages wouldn't have to be covered by a single
incorporation package? (so rather than passing it "entire", you could
pass ["osnet-incorporation", "ips-incorporation", etc.])
line 115, typo "incorporated"
src/web/en/base.shtml et al.
I know it's not this bug, but "CLIENT_API_VERSION" seems weird (yes,
it's a client of the server API, but SERVER_API_VERSION would have been
nicer imho)
General:
It'd be nice to have server-api unit tests, though I'm not sure how
feasible that is when plugging into cherrypy.
Otherwise, looks good I think.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
