On 03/08/12 12:53, Tim Foster wrote:
On 03/ 9/12 06:40 AM, Shawn Walker wrote:
On 03/02/12 18:06, Shawn Walker wrote:
https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-bui/webrev/
src/modules/server/api.py:
gen_allowed_packages(..)
This takes a single fmri (an incorporation) following its dependencies.
Would the API be more useful if it allowed a list of fmris instead,
which would mean all packages wouldn't have to be covered by a single
incorporation package? (so rather than passing it "entire", you could
pass ["osnet-incorporation", "ips-incorporation", etc.])
I purposefully avoided that since you get in to some wacky cases if you
passed ["entire", "osnet-incorporation"]. But I suppose it's up to the
caller to not do silly things.
...
General:
It'd be nice to have server-api unit tests, though I'm not sure how
feasible that is when plugging into cherrypy.
Yeah, that's the exact problem. The BUI currently has to be completely
hand-tested. I've never figured out a good way to handle that; we have
some RFEs open for additional testing.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
