On 03/20/12 04:32, Saurabh Vyas wrote:
Hi All,
Another reminder, please if someone can provide inputs on this fix.
More details in mail below........
for quick ref, webrev location :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7141684-rev4/webrev/
So this isn't the right fix for a few reasons:
* it will show the publisher returned by
get_highest_ranked_publisher() even if that publisher is not
explicitly configured
* it potentially will not show publishers that do not have configured
origins or mirrors
* this change needs a test case
So here are my suggested changes:
line 24: update copyright
line 4531: change this to:
if api_inst.has_publisher(pref_pub):
pubs = [pref_pub]
else:
# Only publisher known is from an installed package and is not
# configured in the image.
pubs = []
lines 4560-4564: delete these
line 4603: change this to:
if p.repository:
origins = p.repository.origins
mirrors = p.repository.mirrors
else:
origins = mirrors = []
lines 4607, 4619, 4630: delete the 'r.'
Add a test case to src/tests/cli/t_pkg_publisher.py.
I think the above will get the desired result.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
