On 03/21/12 04:24, Saurabh Vyas wrote:
...
...
I have made the changes as suggested, updated webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7141684-rev5/webrev/
src/tests/cli/t_pkg_publisher.py:
lines 435-441: This is indented one level too far, so it's currently
being treated as a nested function of test_publisher_properties.
De-indent this and re-run just this test to verify.
Add a test case to src/tests/cli/t_pkg_publisher.py.
I have added test case for this bug, ran the test suite (runs fine).
Just to be sure I just ran the test case I added on the tip of gate
without this fix, and got the traceback.
That's the correct way to test.
Please let me know your thoughts / comments ......
Since I helped you write this, I can't really be your final reviewer.
Someone else will need to review this.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
