On 04/ 7/12 04:02 PM, Alan Coopersmith wrote:
On 04/ 6/12 07:41 PM, Brock Pytlik wrote:
Changes:
$ hg diff -r 2652
diff -r 4c9688c29331 src/zoneproxy/zoneproxy-adm/zoneproxy-adm.c
--- a/src/zoneproxy/zoneproxy-adm/zoneproxy-adm.c Fri Apr 06 16:06:44 2012
-0700
+++ b/src/zoneproxy/zoneproxy-adm/zoneproxy-adm.c Fri Apr 06 19:40:30 2012
-0700
@@ -106,5 +106,4 @@
notify_zoneproxyd(zoneid, remove);
exit(0);
- return 0;
}
Since it's a one line removal, I thought I'd just do this one in the message.
Looks good to me, as long as it doesn't cause you lint problems for failing to
return an int from a function declared to do so (see explanation in the attached
heads up I sent for this change to the system headers) - and sorry about the
damage.
LGTM too. I ran into this yesterday before seeing your mail, and
bludgeoned through the error messages by commenting out $CFLAGS in
src/zoneproxy/Makefile.constants. This is likely a better fix :-)
Brock's fix does cause a lint warning - do we care about that here?
(certainly, we've no automated lint-checking in the pkg-gate)
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
