Brock Pytlik wrote: > On 04/09/12 18:57, Alan Coopersmith wrote: > >On 04/ 8/12 05:50 PM, Brock Pytlik wrote: > >>Hmm, I did run make lint and just double checked it. On build 13, on my > >>machine, > >>when I run 'make lint', I get no complaints about zoneproxy-adm. Maybe I'm > >>using > >>the wrong version of lint or something? I'll mention that when I run make > >>lint, > >>I see a bunch of other lint warnings coming from our cpython modules, so > >>that > >>might need adjusting too. > >If I'm understanding the src/Makefile in the package gate correctly, it's > >not calling the lint rule in $(SUBDIRS) like zoneproxy, but should do so > >with a simple addition of: > > > >lint: $(SUBDIRS) > The one issue with this is that not all of our subdirs have rules for lint. > I'm not sure whether the better approach is to add empty lint rules where > needed, or to instead do something like that clobber does for the pkg dir.
While the typical ON way is to put dummy targets in directories where something doesn't apply (install_h being one notable such target), I don't think that's something we'd want to replicate here. > Since I'm in this space, the other thing I'd like to do is remove setup.py > lint, and instead have lint in the makefile depend on client and pylint. > Thoughts? So the issue that I see is that the top-level lint target never bothers to lint the zoneadm directory. The only C linting that gets done is when you do "cd zoneadm; make lint", at which point you have a bunch of lint warnings, and -mt getting passed erroneously to lint. I guess I don't care whether or not C linting is done exclusively through Makefile infrastructure or not, but we'll need to continue linting the C module source, and that's likely to be harder (or at least duplicative) to do in the Makefiles. I guess I'd explore a hybrid approach -- either stuff the lintable subdirectories into setup.py (which could then simply run "make lint" in each), or jigger the makefile to run "setup.py lint" and then descend into lintable subdirs. FWIW, though, that needn't be part of this wad, which I'd rather get in sooner than later. Lint-cleanliness and a proper infrastructure for it can come soon after. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
