On 04/09/12 11:50, Edward Pilatowicz wrote:
On Fri, Apr 06, 2012 at 02:13:25PM -0700, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7091514-v1
Bug:
7091514 moving driver_alias from 'hermon' to 'mcxnex' fails with 'onu'
only one nit...
src/modules/actions/driver.py
- it seems your adding another check to see if we should run
__usr_sbin_init(), why not just create a property accessor function
for add_drv/rem_drv/update_drv that invokes __usr_sbin_init() if
necessary? although perhaps that's overkill since currently we have
two checks and using an accessor function would require three.
I think that's overkill right now, as you said. If we add more static
methods which use add,rem, or update drv, I'd reconsider.
Thanks for the review,
Brock
otherwise, lgtm.
ed
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
