On 04/13/12 13:49, Danek Duvall wrote:
Brock Pytlik wrote:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7091514-v1
The code looks fine; my comments are truly just nits.
imageplan.py:
- line 2725: rm_alises -> rm_aliases. Similarly on line 3334.
- line 2729: find a way to break the line.
- While, you're there, "preceed" on lines 3289 and 3294 should be
"precede", and "accomodate" on line 3292 should be "accommodate".
- line 3334: I'd move this bit up before the "Done with removals"
comment. I'd also reword slightly:
Update driver alias database to reflect the aliases drivers have
lost in the new image. ...
Thanks for the review! All comments taken.
Brock
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
