On 07/19/12 15:06, Brock Pytlik wrote:
On 07/18/12 14:39, Danek Duvall wrote:
Brock Pytlik wrote:

I've updated the webrev based on the feedback.
New webrev here:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7139873-v2

v1 vs v2:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7139873-v1-v2
Looks like these are the same webrev. Can you upload the v1-v2 webrev
again?

Thanks,
Danek
Oops, sorry about that. It's fixed in place now.

src/modules/client/plandesc.py:
line 654: Since update_image() isn't intended to be called by general consumers, please prefix the function name with '_'.

src/modules/client/image.py:
  Have you done any measuring of peak memory usage after these changes?
  In particular, it looks like the image state will no longer be
  shared between the two images.

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to