On Mon, Jul 23, 2012 at 03:44:47PM -0700, Dan Price wrote:
>
> I'd appreciate review for these fixes:
>
> 7185794 progress output could be less frequent on very slow terminals
> 7185795 pkgrecv -n doesn't print republish column headers anymore
> 7185799 pmcheckforupdate could use some code cleanup
> 7185800 linked progress output could note 'X/X done' at the end
> 7185804 neuter non-functional html downloading in update-refresh script
>
> Shawn has looked at the first draft of these. One important thing
> to note is a small messaging change introduced by 7185800.
>
> https://cr.opensolaris.org/action/browse/pkg/dp/pkg-cleanup-3/
>
lgtm. i only have one comment.
ed
---------
src/checkforupdates.py
- in __check_for_updates(), the last assignment here seems unnecessary:
ret = self.__check_for_updates_cache_only()
if ret != enumerations.UPDATES_UNDETERMINED:
...
...
self.return_status = enumerations.UPDATES_UNDETERMINED
if i'm reading the code right, __check_for_updates_cache_only() always
sets self.return_status to it's return value.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
