On Tue 24 Jul 2012 at 01:32PM, Danek Duvall wrote:
> Dan Price wrote:
> 
> > https://cr.opensolaris.org/action/browse/pkg/dp/pkg-cleanup-3/
> 
> checkforupdates.py:
> 
>   - line 241: no need for str().

Done.

>   - line 295: why not do what the other packaging commands do?

Ok, I lifted some stuff out of the other cmds.

> progress.py:
> 
>   - line 2461: because there's more than one expando here, you should use
>     named expandos:
>     
>         _("%(linked)s linked: %(done)s done") % {
>             "linked": self.li_phase_names[self.major_phase]
>             "done": format_pair( ... )
>         }

Ok, done.

        -dp

-- 
Daniel Price, Solaris Kernel Engineering
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to