Hi Brock,
On 07/24/12 05:44 PM, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7185843-v1
Just a few nits really:
src/tests/api/t_bootenv.py:
line 52 doesn't need the '+=', '=' would be enough I think
line 62, I was thinking the wording of the first sentence could be more
explict, perhaps: "All other test suite tests test the BootEnv
class with, PKG_NO_LIVE_ROOT set in the environment, see the run()
method in Pkg5TestSuite and env_santize(..)"
as I got a bit wary about the 'del' on line 73, without saving the
existing value.
line 87, do we need this given we set it in run(..) -> env_sanitize(..)
anyway?
Otherwise LGTM - looking forward to speedy test runs again!
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
