On 07/27/12 15:57, Dan Price wrote:
I introduced a bug in our terminal handling when TERM isn't set or
is set to a bogus value. Here's a fix:
https://cr.opensolaris.org/action/browse/pkg/dp/setupterm/
If possible I'd like to get this pushed today, so a speedy review
would be much appreciated...
-dp
Only a couple of questions. Are there tests somewhere that show what
happens to the CLI when a PrintEngineException is raised. Assuming those
exist, this changeset lgtm, if not, then I think a test that runs the
pkg cli with term set to nonsense is needed to demonstrate that we
handle the exception correctly.
The other question I have is whether teardown is called even if the test
fails and even if the test is ctrl-c'd. If it's not, I'm concerned that
the term might not get reset appropriately. Maybe this needs a place in
impl_teardown as well since otherwise it looks to me like someone
pounding ctrl-c over and over might escape out.
Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
