On Wed 01 Aug 2012 at 03:07PM, Shawn Walker wrote:
> >Ok, now please take a look. Note that I already noticed the
> >one-line typo 'code _execute_child() code' and cleaned it up.
>
> src/tests/cli/t_pkg_terminal.py:
> lines 30, 33, 34: unused import
>
> lines 69-70: two newlines after class definitions
>
> src/tests/pkg5unittest.py:
> lines 340, 341: s/it's/its/
All fixed.
> lines 360-361: Are these intended to be before 'args ='? Seems
> odd to run any executable with '-c'...
My assumption is that python assumes that if you set shell=True AND
you set executable, then you know what you are doing.
Thanks--
-dp
--
Daniel Price, Solaris Kernel Engineering
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
