On 08/06/12 20:51, Tim Foster wrote:
Hi there,

I've a code review here that fixes a problem where zone installs fail if
the user has a $http_proxy environment variable set.

The fix makes the 'syspub/0' transport operations special, ensuring that
we force an empty proxy value when those (as opposed not setting any
proxy, which causes libcurl to look for $http_proxy values)

I've added lots of code comments explaining how this works, though
perhaps I went overboard?

https://cr.opensolaris.org/action/browse/pkg/timf/sysrepo-no-envproxy

src/modules/misc.py:
  lines 2433, 2435: I think technically, the '*' should be '==' not
    'in'.  That's how libcurl checks it anyway.

Otherwise, this seems like the best compromise for now.

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to