On 08/ 8/12 08:03 AM, Brock Pytlik wrote:
> This all seems reasonable to me. The comments are definitely helpful
> and I don't think overboard at all.
On 08/ 8/12 08:17 AM, Shawn Walker wrote:
On 08/06/12 20:51, Tim Foster wrote:
https://cr.opensolaris.org/action/browse/pkg/timf/sysrepo-no-envproxy
src/modules/misc.py:
lines 2433, 2435: I think technically, the '*' should be '==' not
'in'. That's how libcurl checks it anyway.
Otherwise, this seems like the best compromise for now.
Great stuff, thanks for the reviews - good catch on the '*'. I'll make
that change, test and putback.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
