On Tue, Aug 28, 2012 at 11:00:29AM -0700, Shawn Walker wrote:
> On 08/27/12 18:35, Edward Pilatowicz wrote:
> >hey all,
> >
> >shawn found a facet bug that in introduced with the original linked
> >images putback (oops). i've got a fix for it here:
> >
> > https://cr.opensolaris.org/action/browse/pkg/edp/pkg.change-facet/webrev
> > 7193711 change-facet doesn't restore content for explicitly false facets
>
> src/tests/cli/t_change_facet.py:
> line 68: Drop spaces around '[' and ']'
>
that line was actually changed to:
self.plist = self.pkgsend_bulk(self.rurl, self.pkg_A)
self.plist_B = self.pkgsend_bulk(self.rurl, self.pkg_B)
(this change was made because including pkg_b in self.plist broke other
test cases make the assumption that self.plist only contains pkg_A.)
> line 291: s/an/a/
>
done.
> Thanks for expanding the test case.
>
yeah. i spent some time studying the changes to make sure i wasn't
going to break anything else and expanded the test case to verify other
edge cases i was concerned about (it also led me to finding the dead
code in pkg_solver.py and cleaning that up).
> LGTM, but get one other reviewer if you can.
>
sure.
> Is this intended for U1?
>
i don't know. i was going to putback to the default branch and then ask
folks (danek) if they want me to put this fix into U1 as well. (i'm
comfortable enough with this fix to be willing to do that.)
thanks again for helping with this.
ed
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
