Edward Pilatowicz wrote:
> https://cr.opensolaris.org/action/browse/pkg/edp/pkg.change-facet/webrev
imageplan.py:
- line 317: Python doesn't need parens here
- line 368: can this be re-flowed now?
t_change_facet.py:
- line 252: this doesn't read well. Perhaps you mean something like
"Verify that resetting a facet explicitly set to false restores the
delivered content."?
- I'll also point out that this test seems to do more than what either
the name or the docstring claim. Are we missing these basic tests
(like the graf starting at line 291) elsewhere? The last three tests
(from line 306 on) seem relevant. Not sure about the rest.
- line 291: "an random" -> "a random"
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
