On Tue, Aug 28, 2012 at 02:21:48PM -0700, Shawn Walker wrote:
> Greetings,
>
> The following webrev contains changes for the following RFE:
>
>   7140597 facets are ORed even between different top-level facet
>           categories
>
>   https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-facet/webrev/
>

sorry for the delay on 7193711, i didn't realize that this was dependent on
it.

----------
src/modules/_varcet.c

- since the "else" block is a single line, you could make the code
  easier to read by changing:
        if (facet == NULL) {
  to:
        if (facet != NULL) {

- the "next_facet" label is now unused.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to