Shawn Walker wrote: > Greetings, > > The following diff contains a fix for the following issue: > > 7196957 pkg.depotd fails to read passphrase-protected ssl key when > using smf or exec authentication > > > I've manually verified that: > > * the decrypted key file is automatically removed still after > the depot server binds to the socket > > * that it works when using SMF as an authentication source
Are you sure that letting garbage collection be the point where the file gets closed is safe? If Python decides it could garbage collect key_data before the data is read, then we're toast. Does the configuration require a pathname to the key data, or could it take key_data directly as an open file handle? > I am considering putting this into a respin for U1 given it's trivial > nature and the importance of this functionality to some users, although > I'd note that it's been broken since b144. So let's leave it for an SRU. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
