On 09/08/12 10:20, Danek Duvall wrote:
Shawn Walker wrote:
Greetings,
The following diff contains a fix for the following issue:
7196957 pkg.depotd fails to read passphrase-protected ssl key when
using smf or exec authentication
I've manually verified that:
* the decrypted key file is automatically removed still after
the depot server binds to the socket
* that it works when using SMF as an authentication source
Are you sure that letting garbage collection be the point where the file
gets closed is safe? If Python decides it could garbage collect key_data
before the data is read, then we're toast. Does the configuration require
a pathname to the key data, or could it take key_data directly as an open
file handle?
Now with unit testing:
https://cr.opensolaris.org/action/browse/pkg/swalker/depot-ssl/webrev/
Doesn't cover the SMF case, but finally gives us a real unit test of
Depot HTTPS for the 'no passphrase' server key case and the 'passphrase,
but use a programs to get password' case.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
