Tim Foster wrote:
> https://cr.opensolaris.org/action/browse/pkg/timf/apache-testsuite-cleanup
pkg5unittest.py:
- line 3222, et al: seems to me that "ac" should be a property of the
class, doing the work of 3247-3250 on demand, rather than having that
statically decided at registration.
- In the cases where a kill() fails, would it be worth logging a message,
even if only a debug message? Or is it basically impossible?
t_pkg_install.py:
- line 766: need space before close-bracket
t_pkg_sysrepo.py:
- line 591: you're now stopping the sysrepo for this test, but you didn't
add similar lines for the other tests. Is it not generally necessary?
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
