On 11/27/12 11:34 AM, Danek Duvall wrote:
https://cr.opensolaris.org/action/browse/pkg/timf/apache-testsuite-cleanup
Thanks for taking a look,
pkg5unittest.py:
- line 3222, et al: seems to me that "ac" should be a property of the
class, doing the work of 3247-3250 on demand, rather than having that
statically decided at registration.
That's reasonable, I'll change that into a property, in line with the
way SingleDepotTestCase deals with 'dc'.
- In the cases where a kill() fails, would it be worth logging a message,
even if only a debug message? Or is it basically impossible?
No, that's a good idea - ultimately if we've been unable to kill an
Apache instance, I'd expect to see all sorts of entrails from subsequent
test cases as they fail to start processes due to ports being in use. A
log message can't hurt.
t_pkg_install.py:
- line 766: need space before close-bracket
Thanks, fixed.
t_pkg_sysrepo.py:
- line 591: you're now stopping the sysrepo for this test, but you didn't
add similar lines for the other tests. Is it not generally necessary?
My mistake - I'd been experimenting around with making that into a
persistent test class and had been stopping and starting the sysrepo in
the test methods, but decided we didn't really gain anything by it - I
forgot to remove that line of code.
Instead, as part of the test teardown, we'll stop any running depots
before the next test case runs, as happens elsewhere in this class.
I'll push these changes one the test run completes. Thanks again for
the review.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
