On 12/13/12 08:53 AM, Shawn Walker wrote:
https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-15967219/webrev
LGTM. The only question I have (and I see this used elsewhere in the
tests, so I'm probably missing something) is why do we have:
def gen_php_links():
for lname in ("mod_php5.so",):
lpath = os.path.join(self.img_path(), "usr",
"apache2", "2.2", "libexec", lname)
yield lpath
and not:
def gen_php_links():
lpath = os.path.join(self.img_path(), "usr",
"apache2", "2.2", "libexec", "mod_php5.so")
yield lpath
Other than that, all good.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
