On 12/12/12 12:26, Tim Foster wrote:
On 12/13/12 08:53 AM, Shawn Walker wrote:
https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-15967219/webrev
LGTM. The only question I have (and I see this used elsewhere in the
tests, so I'm probably missing something) is why do we have:
def gen_php_links():
for lname in ("mod_php5.so",):
lpath = os.path.join(self.img_path(), "usr",
"apache2", "2.2", "libexec", lname)
yield lpath
and not:
def gen_php_links():
lpath = os.path.join(self.img_path(), "usr",
"apache2", "2.2", "libexec", "mod_php5.so")
yield lpath
Other than that, all good.
Just laziness basing this on code that is setup to easily allow for
other links to be added. If you'd like me to change all of them to be
consistent, that's fine. I'm indifferent on this particular item.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
