On 12/13/12 20:34, Saurabh Vyas wrote:
On 12/14/12 01:31, Shawn Walker wrote:
Greetings,
The webrev below contains fixes for the following issues:
15998653 variant and mediator tagged actions with same path ignored
in one pkg
webrev:
https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-med-var/webrev/
Hi Shawn,
This LGTM.
Just some nits,
src/modules/manifest.py
- should we also a empty dict created for 'odict' too.
No, and actually I should have deleted the empty dict.
- some code level comment about 'dictify()' would be really appreciated.
I've added a brief comment explaining the intent of the routine.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
