On 12/15/12 05:44 AM, Shawn Walker wrote:
https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-med-var/webrev/
src/modules/manifest.py
- should we also a empty dict created for 'odict' too.
No, and actually I should have deleted the empty dict.
- some code level comment about 'dictify()' would be really appreciated.
I've added a brief comment explaining the intent of the routine.
I didn't see those changes in this particular version of the webrev, but
assuming you've made them in your workspace, LGTM.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
