On 01/31/13 09:37, Bart Smaalders wrote:
On 01/30/13 06:29 PM, Shawn Walker wrote:
Greetings,
The following webrev contains fixes (4 lines of real change and 61 lines
of unit test code) for the following issues:
16246160 unmediated actions can be dropped when they become mediated
in new pkg versions
16246189 mediated links with new targets can be ignored during pkg
upgrades
https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-med-fixes/webrev/
Thanks to Bart for helping me find the cause.
...
This looks correct, Shawn. I take it the original tests failed
as expected when frozenset was changed to tuple?
No, without any changes I could reliably get the new test to fail. We
previously did not have any tests for mediated links with changing targets.
So the primary fix was the a.attrs[a.key_attr]; however, I have no doubt
that the tuple/frozenset could have come back to bite us later.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
