On 01/31/13 09:47, Erik Trauschke wrote:
On 01/31/13 09:37 AM, Bart Smaalders wrote:
On 01/30/13 06:29 PM, Shawn Walker wrote:
Greetings,
The following webrev contains fixes (4 lines of real change and 61 lines
of unit test code) for the following issues:
16246160 unmediated actions can be dropped when they become mediated
in new pkg versions
16246189 mediated links with new targets can be ignored during pkg
upgrades
https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-med-fixes/webrev/
Thanks to Bart for helping me find the cause.
...
This looks correct, Shawn. I take it the original tests failed
as expected when frozenset was changed to tuple?
Why is that changed to tuple from set anyway? If I understand this
correctly, akey pretty much represents a path, so how can there be
duplicates?
Since frozenset() doesn't guarantee order, it's possible that a path may
match a mediator-implementation value and vice versa. With that said,
I'm unable to construct a scenario in which this change actually helps.
However, it seems to me that dictify() output should be consistent.
That is, always produce the same output given the same input since it is
essentially a "hashing" function of sorts.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
