On 02/18/13 19:07, Tim Foster wrote:
Hi there,
I've a small code review here that fixes two bugs with the
system-repository and the pkg/depot services.
With this change, the Apache based pkg/depot service will deflate
catalog parts given the right request headers, which will improve
install times (it already deflates other compressible metadata)
I'm also fixing a hard-to-detect bug with the way we used RewriteRules
in both the system-repository and pkg/depot services, and adding a test
that will hopefully catch some instances of that problem should the
bugfix regress.
https://cr.opensolaris.org/action/browse/pkg/timf/depot-deflate/depot-deflate-webrev/
src/tests/cli/t_depot_config.py:
line 648: 'testpkg5/u' ?
src/util/apache2/depot/depot.conf.mako:
I assume that if DOCUMENT_ROOT contains unexpected characters that
won't make this stuff go haywire? (backslashes, spaces, etc.)
lines 246-248: shouldn't that be /catalog/\d/.* (catalog/0/ and
catalog/1/catalog.attrs cases)? Don't we also want a max-age of 86400
on catalog requests?
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
