Hi Shawn
On 02/20/13 08:47 AM, Shawn Walker wrote:
On 02/18/13 19:07, Tim Foster wrote:
https://cr.opensolaris.org/action/browse/pkg/timf/depot-deflate/depot-deflate-webrev/
Thanks for taking a look.
src/tests/cli/t_depot_config.py:
line 648: 'testpkg5/u' ?
Oops, thanks.
src/util/apache2/depot/depot.conf.mako:
I assume that if DOCUMENT_ROOT contains unexpected characters that
won't make this stuff go haywire? (backslashes, spaces, etc.)
Right, %{DOCUMENT_ROOT} is expanded internally by Apache, not by Mako. I
wouldn't expect that value to be modified though, since that directory
is created dynamically in /system/volatile/pkg/depot/htdocs.
lines 246-248: shouldn't that be /catalog/\d/.* (catalog/0/ and
catalog/1/catalog.attrs cases)?
Nope, these paths are the final rewritten paths to the file contents of
the repository, so we're actually plucking the catalog parts from the
repository itself, eg
/space/repo/publisher/solaris/catalog/catalog.attrs
Even if that weren't the case, the apache depot doesn't support
catalog/0/ operations anyway (our versions response looks like:
pkg-server 358564628c02
publisher 0 1
versions 0
catalog 1
file 1
manifest 0
admin 0
search 0 1
)
> Don't we also want a max-age of 86400 on catalog requests?
Hmm, good point. ipkg uses
Cache-Control: must-revalidate, no-transform, max-age=14400
for catalog parts, but pkg.depotd seems to use 86400, so I'll go with
that value, and make sure that we still use no-cache for catalog.attrs.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
