On 02/19/13 03:57 PM, Shawn Walker wrote: --8<--
src/pkgrepo.py: line 1028: extra newline lines 1503-1506: I don't think we should have the allow-timestamp thing here, it doens't make sense. I'd just drop the first if condition and simplify. src/tests/cli/t_pkgrecv.py: lines 819-824: missing ' ' after ':'; this goes for all of the other test files where this was copy/pasted as well line 847: extra newline src/tests/cli/t_pkgrepo.py: line 2228: insert another newline general comment: I don't see any tests here to see what happens when a user only specifies a key file and not a cert file, when they don't have permission to read the key/cert, or when they specify a file that doesn't exist, or when the file is zero-length. Can you add tests for those for each command and provide sample error output for each case from *one* of the commands? I know that's a non-trivial amount of work, but inevitably, it will trip us up later.
new webrev: https://cr.opensolaris.org/action/browse/pkg/erisch/16193298_2/webrev/ incremental: https://cr.opensolaris.org/action/browse/pkg/erisch/16193298_1-2/webrev/ Thanks Erik _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
