Erik Trauschke wrote: > On 02/20/13 03:34 PM, Shawn Walker wrote: > >On 02/20/13 14:51, Erik Trauschke wrote: > >... > >>incremental: > >>https://cr.opensolaris.org/action/browse/pkg/erisch/16193298_1-2/webrev/ > > > >src/tests/cli/t_pkgrecv.py: > >lines 824-834: nitty, but for the cases where you have a line > >continuation, can you indent them 4 spaces (828, 830)? same applies to > >other files where you have arg_dict. > > then it's indented 8 spaces from the original start of continuation. That > seems wrong to me. I know it looks stupid, though.
I guess one way to think of it is that the 4-space indent after the open brace isn't a continuation, it's just the correct indentation level after an open brace defining a dict. Then the extra four spaces for a continuation line within that is just the usual 4-space indent for a continuation. :) Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
