Hi there,
I've got a small code review for a mistake I made when putting back
16292464, where I forgot to add the "$$" argument when calling ppriv in
the svc:/application/pkg/depot method script.
I've filed this as:
16412707 pkg/depot method script misusing ppriv
The fix is small enough that I've just inlined it below.
Apologies for not catching this sooner.
cheers,
tim
timf@kura[448] hg diff
diff --git a/src/svc/svc-pkg-depot b/src/svc/svc-pkg-depot
--- a/src/svc/svc-pkg-depot
+++ b/src/svc/svc-pkg-depot
@@ -226,7 +226,7 @@
cmd="start"
run_depot
# drop privileges now that we've written our configuration
- /usr/bin/ppriv -s E=basic,net_privaddr
+ /usr/bin/ppriv -s E=basic,net_privaddr $$
run_htcacheclean
emsg=$(/usr/bin/printf ${FAILED_TO_RUN} start)
${HTTPD} -f ${depot_runtime_dir}/depot_httpd.conf \
@@ -238,7 +238,7 @@
cmd="graceful"
run_depot
# drop privileges now that we've written our configuration
- /usr/bin/ppriv -s E=basic,net_privaddr
+ /usr/bin/ppriv -s E=basic,net_privaddr $$
kill_htcacheclean
run_htcacheclean
emsg=$(/usr/bin/printf ${FAILED_TO_RUN} refresh)
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
