tags 604687 + upstream confirmed patch
thanks
Le samedi 29 octobre 2011 19:01:19 Rémi Denis-Courmont, vous avez écrit :
> Le vendredi 21 octobre 2011 02:11:32 Jiggy Bau, vous avez écrit :
> > Thanks for supplying the patch. I managed to compile it after some
> > trouble with a missing libavcodec. I then ran it with '-vv' and '--vout
> > xv' args. Output is attached. Hopefully you can make some sense of it.
>
> Not much. VLC does not find any known XVideo picture formats nor any
> unknown ones. Normally, that would mean the adaptors don't provide any
> format at all.
Ah nevermind that. VLC is probably confused by the mixed endianess between the
CPU and the GPU. This patch should fix it.
--
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis
diff --git a/modules/video_output/xcb/xvideo.c b/modules/video_output/xcb/xvideo.c
index 1f3813f..4fc7540 100644
--- a/modules/video_output/xcb/xvideo.c
+++ b/modules/video_output/xcb/xvideo.c
@@ -134,9 +134,6 @@ static bool CheckXVideo (vout_display_t *vd, xcb_connection_t *conn)
static vlc_fourcc_t ParseFormat (vout_display_t *vd,
const xcb_xv_image_format_info_t *restrict f)
{
- if (f->byte_order != ORDER && f->bpp != 8)
- return 0; /* Argh! */
-
switch (f->type)
{
case XCB_XV_IMAGE_FORMAT_INFO_TYPE_RGB:
@@ -156,6 +153,12 @@ static vlc_fourcc_t ParseFormat (vout_display_t *vd,
return VLC_CODEC_RGB24;
break;
case 16:
+ if (f->byte_order != ORDER)
+ {
+ msg_Err (vd, "mixed endian XVideo RGB format %"PRIx32
+ " (%.4s)", f->id, f->guid);
+ return 0;
+ }
if (f->depth == 16)
return VLC_CODEC_RGB16;
if (f->depth == 15)
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
