Hi,
On Wednesday 03 August 2016 14:52:02 James Cowgill wrote:
> While this could be patched into the Debian version, it would be
> preferable to have a new upstream release.
>
> Pedro, if you do make a new release, could you include this patch as well?
>
> https://sources.debian.net/src/kmidimon/0.7.5-2/debian/patches/01-remove-uni
> nstall-target.patch/
I can't promise a deadline for the next kmidimon release, because I have
another pending release much more mature right now: drumstick-1.1, and this
library shall be required by a new kmidimon, along with Qt5. This is a similar
situation to what happened with drumstick-1.0, kmetronome-1.0 and vmpk-0.6
releases that have not been available for Debian and Ubuntu users since then.
So I guess that the same may be true for drumstick-1.1/kmidimon and Debian
users wanting the latest versions will need to build from sources, requiring
both install and uninstall targets.
I don't want to take your patch removing uninstall for everyone, but I don't
mind to wrap the uninstall chuck with "if (NOT TARGET uninstall)", though.
Below is an alternate patch. But before applying any patch, I would like to
know why is it necessary. Is Debian breaking the build system of every project
that offers a custom uninstall target?
Regards,
Pedro
Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt (revision 200)
+++ CMakeLists.txt (working copy)
@@ -128,12 +128,14 @@
"${CMAKE_SOURCE_DIR}/kmidimon.spec"
IMMEDIATE @ONLY)
-CONFIGURE_FILE(
- "${CMAKE_SOURCE_DIR}/cmake_admin/cmake_uninstall.cmake.in"
- "${CMAKE_CURRENT_BINARY_DIR}/cmake_uninstall.cmake"
- IMMEDIATE @ONLY)
-ADD_CUSTOM_TARGET(uninstall
- "${CMAKE_COMMAND}" -P
"${CMAKE_CURRENT_BINARY_DIR}/cmake_uninstall.cmake")
+if (NOT TARGET uninstall)
+ CONFIGURE_FILE(
+ "${CMAKE_SOURCE_DIR}/cmake_admin/cmake_uninstall.cmake.in"
+ "${CMAKE_CURRENT_BINARY_DIR}/cmake_uninstall.cmake"
+ IMMEDIATE @ONLY)
+ ADD_CUSTOM_TARGET(uninstall
+ "${CMAKE_COMMAND}" -P
"${CMAKE_CURRENT_BINARY_DIR}/cmake_uninstall.cmake")
+endif()
ADD_CUSTOM_TARGET ( tarball
COMMAND mkdir -p kmidimon-${VERSION}
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
