Hi, On 03/08/16 19:46, Pedro Lopez-Cabanillas wrote: > On Wednesday 03 August 2016 14:52:02 James Cowgill wrote: >> While this could be patched into the Debian version, it would be >> preferable to have a new upstream release. >> >> Pedro, if you do make a new release, could you include this patch as well? >> >> https://sources.debian.net/src/kmidimon/0.7.5-2/debian/patches/01-remove-uni >> nstall-target.patch/ > > I can't promise a deadline for the next kmidimon release, because I have > another pending release much more mature right now: drumstick-1.1, and this > library shall be required by a new kmidimon, along with Qt5. This is a > similar > situation to what happened with drumstick-1.0, kmetronome-1.0 and vmpk-0.6 > releases that have not been available for Debian and Ubuntu users since then. > > So I guess that the same may be true for drumstick-1.1/kmidimon and Debian > users wanting the latest versions will need to build from sources, requiring > both install and uninstall targets.
Hopefully the same situation won't happen this time. I think the normal maintainers for those Debian packages haven't been very active. > I don't want to take your patch removing uninstall for everyone, but I don't > mind to wrap the uninstall chuck with "if (NOT TARGET uninstall)", though. > Below is an alternate patch. But before applying any patch, I would like to > know why is it necessary. Is Debian breaking the build system of every > project > that offers a custom uninstall target? The FindKDE4 module has installed an "uninstall" target into all downstream projects for ages (>= 10 years). Until recently kdelibs also added a 'cmake_policy(SET CMP0002 OLD)' line to the top of the KDE4 module. This suppresses the error about duplicate targets. Now that the policy line has been removed, cmake will error out on duplicate targets. Commit which caused this error (introduced in kdelibs 4.14.22): https://github.com/KDE/kdelibs/commit/dda2199d601491c6ceb07b5f11c8696216558623 Since KDE4 also ships an uninstall target, I see no reason to keep the one in kmidimon. Thanks, James
signature.asc
Description: OpenPGP digital signature
_______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
