----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/63/ -----------------------------------------------------------
(Updated 2009-02-28 08:23:30.689538) Review request for Plasma and Aaron Seigo. Changes ------- Fixes: * got rid of the m_doingIntroAnimation variable as suggested * I added an animation for the selected tab * Reduced the speed of the animation to 200ms from 250ms. * by uncommenting line 305 the background of the tabbar is faded in. Remaining Issues: * Didn't test the animation when the panel occupied by kickoff is vertically aligned * The timer of the animation is started whenever the widget receives a showEvent. Since in case of plasmoids the showEvent is always an internal showEvent handled _before_ the widget is shown I use a singleShot Timer introducing a delay of 500 ms for the animation to start. That is an awkward hack. There should be a way to start the animation immediately after kickoff is fully visible to the user. Any Ideas what I could do to remedy this? Summary ------- A little animation that mimics the behaviour of my sony erricsson handy whenever I get to the main menu. The Icons in kickoff's tabbar are all placed at the center of the tabbar before moving towards their intended location when the menu is displayed. It's a hack as of now and doesn't even work when the panel is placed on the right or left screen edge. But that's pretty easy to fix if you guys like that behaviour. I am not sure, maybe the thing is superfluous but hey, I like small useless animations. Diffs (updated) ----- KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.h 932966 KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp 932966 Diff: http://reviewboard.kde.org/r/63/diff Testing ------- the animation doesn't work (yet) if the panel is placed on the right or left screen edge. But adding support for that is pretty straightforward. Thanks, Mohammad Mehdi _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
