> On 2009-03-02 21:25:55, Aaron Seigo wrote: > > the patch didn't make it, it seems. can you try to upload it again? > > > > in any case, i don't think we _really_ need an animation for when it isn't > > a popup and just shown full on the desktop, which would make the .5s timer > > unneccesary?
Thanks for the hint :-). I'll upload the patch again. Regarding the "shown fully on the desktop", well, with "shown fully on the desktop" I meant being complete and visible (to the user) as a popup after the K button is called, so I actually meant the popup :-). Anyway, that is the point when the animation should start, i.e. kickoff has been opened as a popup and the tabbar is fully visible to the user. Immediately after that the animation should begin and not last more than 150-200 ms to avoid annoying the user. How do I get notified about the popup being visible to the user. I am looking for something like a normal (not internal) showEvent. Any ideas how to do that? - Mohammad Mehdi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/63/#review339 ----------------------------------------------------------- On 2009-02-28 08:23:30, Mohammad Mehdi Salem Naraghi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/63/ > ----------------------------------------------------------- > > (Updated 2009-02-28 08:23:30) > > > Review request for Plasma and Aaron Seigo. > > > Summary > ------- > > A little animation that mimics the behaviour of my sony erricsson handy > whenever I get to the main menu. The Icons in kickoff's tabbar are all placed > at the center of the tabbar before moving towards their intended location > when the menu is displayed. It's a hack as of now and doesn't even work when > the panel is placed on the right or left screen edge. But that's pretty easy > to fix if you guys like that behaviour. I am not sure, maybe the thing is > superfluous but hey, I like small useless animations. > > > Diffs > ----- > > KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.h 932966 > KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp 932966 > > Diff: http://reviewboard.kde.org/r/63/diff > > > Testing > ------- > > the animation doesn't work (yet) if the panel is placed on the right or left > screen edge. But adding support for that is pretty straightforward. > > > Thanks, > > Mohammad Mehdi > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
