-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/
-----------------------------------------------------------
(Updated 2009-08-21 12:47:32.535164)
Review request for Plasma.
Changes
-------
-removed the white spaces, they should all be gone
-fixed the "} else {"s
-changed the casts in notifierview.cpp to static_cast instead of C style
-moved lines 140 and 141 of devicenotifier.cpp inside the if
Summary
-------
This is a patch that modifies quite heavily the behaviour of the Device
Notifier.
It comes from here:
http://kde-look.org/content/show.php/Device+Manager?content=106051
It can show the not removable devices too, it can mount them automatically or
with a click, since the "eject" button is a "mount" button when the volume is
umounted. So that guy on the dot will be ok.
It can hide some items in the same way as Dolphin's places (hide item/ show
all).
Finally, it shows the various opening actions under the device instead of
calling that xp-ish window.
Diffs (updated)
-----
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt
1013960
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui
PRE-CREATION
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
1013960
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp
1013960
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
1013960
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
1013960
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h
1013960
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp
1013960
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h
1013960
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp
1013960
Diff: http://reviewboard.kde.org/r/1370/diff
Testing
-------
I'm using it every day since I released 0.1 on Kde-look. I tried all the
options on my pc and they work. Some people on kde-look posted some comments
about some problems, but it seems to me they are very particular cases, so in
my opinion it is quite stable to go in trunk, but anyway review it! :)
Screenshots
-----------
screen
http://reviewboard.kde.org/r/1370/s/183/
Thanks,
Giulio
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
